Add criterion benchmarks for icu_properties#7712
Open
afrdbaig7 wants to merge 1 commit intounicode-org:mainfrom
Open
Add criterion benchmarks for icu_properties#7712afrdbaig7 wants to merge 1 commit intounicode-org:mainfrom
afrdbaig7 wants to merge 1 commit intounicode-org:mainfrom
Conversation
Contributor
Author
|
@sffc can you please review it |
Covers CodePointSetData and CodePointMapData lookups. Fixes unicode-org#1665.
afrdbaig7
force-pushed
the
add-properties-bench
branch
from
f2bb108 to
cdbaabe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds benchmarks for CodePointSetData and CodePointMapData using criterion, following the same pattern as the codepointtrie benchmarks in icu_collections. Benches covered: - set/contains and set/iter_ranges for Alphabetic - map/get for GeneralCategory and Script - map/get_set_for_value
Fixes #1665